From 5ce4dd4d15c9f59155edd7bd7c18b142494cec79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Garc=C3=ADa?= Date: Tue, 4 Mar 2014 01:40:10 +0100 Subject: [PATCH] Control width blacklisting feed are down, cron.php manage the status of this feeds --- admin/index.php | 3 +++ admin/subscriptions.php | 1 + app/classes/Planet.class.php | 26 ++++++++++++++++++++------ app/classes/PlanetFeed.php | 9 ++++++++- app/l10n/en.lang | 4 ++++ app/l10n/fr.lang | 4 ++++ app/lib/lib.opml.php | 5 +++-- 7 files changed, 43 insertions(+), 9 deletions(-) diff --git a/admin/index.php b/admin/index.php index 28f7198..76ddc98 100755 --- a/admin/index.php +++ b/admin/index.php @@ -99,6 +99,7 @@ + @@ -118,10 +119,12 @@ } else { echo _g('Not in cache'); } + $check_is_down = $opml_person->getIsDown() === '1' ? 'checked="cheched"' : ''; ?> + value="1" /> diff --git a/admin/subscriptions.php b/admin/subscriptions.php index ea2f113..3612666 100755 --- a/admin/subscriptions.php +++ b/admin/subscriptions.php @@ -48,6 +48,7 @@ function removeSlashes(&$item, $key){ $person['name'] = $feed->get_title(); $person['website'] = $feed->get_permalink(); $person['feed'] = $feed->feed_url; + $person['isDown'] = '0'; $oldOpml->entries[] = $person; } diff --git a/app/classes/Planet.class.php b/app/classes/Planet.class.php index 81a71fe..3c76378 100644 --- a/app/classes/Planet.class.php +++ b/app/classes/Planet.class.php @@ -97,7 +97,8 @@ public function loadOpml($file) new PlanetFeed( $opml_person['name'], $opml_person['feed'], - $opml_person['website'] + $opml_person['website'], + $opml_person['isDown'] ) ); } @@ -110,11 +111,14 @@ public function loadOpml($file) public function loadFeeds() { foreach ($this->people as $feed) { - $feed->set_timeout(-1); - $feed->init(); - $this->items = array_merge($this->items, $feed->get_items()); - } + //Is down it's filled by cron.php, $Planet->download(1.0) proccess + if (!$feed->isDown) { + $feed->set_timeout(-1); + $feed->init(); + $this->items = array_merge($this->items, $feed->get_items()); + } + } $this->sort(); } @@ -124,8 +128,8 @@ public function loadFeeds() */ public function download($max_load=0.1) { - $max_load_feeds = ceil(count($this->people) * $max_load); + $opml = OpmlManager::load(dirname(__FILE__).'/../../custom/people.opml'); foreach ($this->people as $feed) { //Avoid mass loading with variable cache duration @@ -140,6 +144,7 @@ public function download($max_load=0.1) //Load feed $feed->init(); + $isDown = ''; // http://simplepie.org/wiki/reference/simplepie/merge_items ? //Add items to index @@ -148,8 +153,17 @@ public function download($max_load=0.1) $this->items = array_merge($this->items, $items); } else { $this->errors[] = new PlanetError(1, 'No items : '.$feed->getFeed()); + $isDown = '1'; + } + + //Mark if the feed is temporary unavailable + foreach ($opml->entries as $key => $entrie) { + if ($feed->getFeed() === $entrie['feed']) { + $opml->entries[$key]['isDown'] = $isDown; + } } } + OpmlManager::save($opml, dirname(__FILE__).'/../../custom/people.opml'); } public function sort() diff --git a/app/classes/PlanetFeed.php b/app/classes/PlanetFeed.php index a6c7aab..7c79471 100644 --- a/app/classes/PlanetFeed.php +++ b/app/classes/PlanetFeed.php @@ -9,12 +9,14 @@ class PlanetFeed extends SimplePie public $name; public $feed; public $website; + public $isDown; - public function __construct($name, $feed, $website) + public function __construct($name, $feed, $website, $isDown) { $this->name = $name; $this->feed = $feed; $this->website = $website; + $this->isDown = $isDown; parent::__construct(); $this->set_item_class('PlanetItem'); $this->set_cache_location(dirname(__FILE__).'/../../cache'); @@ -39,6 +41,11 @@ public function getWebsite() return $this->website; } + public function getIsDown() + { + return $this->isDown; + } + public function compare($person1, $person2) { return strcasecmp($person1->name, $person2->name); diff --git a/app/l10n/en.lang b/app/l10n/en.lang index 64d5a82..ff49307 100644 --- a/app/l10n/en.lang +++ b/app/l10n/en.lang @@ -113,6 +113,10 @@ Website link Feed link +# Translation note: ** String needs translation ** +;Unavailable +Unavailable + # Translation note: ** String needs translation ** ;Not in cache Not in cache diff --git a/app/l10n/fr.lang b/app/l10n/fr.lang index 6247652..4e2a568 100755 --- a/app/l10n/fr.lang +++ b/app/l10n/fr.lang @@ -90,6 +90,10 @@ Lien du site Lien du Flux +;Unavailable +Indisponible + + ;Not in cache Pas en cache diff --git a/app/lib/lib.opml.php b/app/lib/lib.opml.php index 7767979..b777f15 100644 --- a/app/lib/lib.opml.php +++ b/app/lib/lib.opml.php @@ -13,7 +13,8 @@ class opml 'TEXT' => 'name', 'TITLE' => 'name', 'XMLURL' => 'feed', - 'DESCRIPTION' => 'description' + 'DESCRIPTION' => 'description', + 'ISDOWN' => 'isDown' ); @@ -95,7 +96,7 @@ public function save($opml, $file){ $out.= ''."\n"; $out.= ''."\n"; foreach ($opml->entries as $person){ - $out.= ''."\n"; + $out.= ''."\n"; } $out.= ''."\n"; $out.= '';