Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting for the site favicon #176

Open
revi opened this issue Jun 30, 2022 · 2 comments
Open

Add a setting for the site favicon #176

revi opened this issue Jun 30, 2022 · 2 comments
Labels
feature New features that are ready to be worked on.

Comments

@revi
Copy link
Contributor

revi commented Jun 30, 2022

Mostly low-priority cosmetic request: when I have a LOT of tabs (like I do here), I would like to differentiate the tabs based on the icon. (and cosmetic reasons too)

@samwilson
Copy link
Owner

This is a great idea. I wonder what the best way to do it is.

One simple way to do this is for site admins just to add a favicon.ico to the public/ directory. It doesn't have to be managed by the app at all.

https://favicon.io/ is an easy way to create the file.

There are other sizes and types of favicon that can be useful, so it's still worth adding support to Twyne, I think.

@samwilson samwilson added the feature New features that are ready to be worked on. label Jul 1, 2022
@samwilson samwilson changed the title Favicon Add a setting for the site favicon Jul 1, 2022
@revi
Copy link
Contributor Author

revi commented Jul 1, 2022

Maybe bundle a default favicon somewhere (generated via favicon.io or something) and presence of public/favicon.ico overriding the default favicon? Or just display favicon when public/favicon.ico without the bundled favicon? Also while we are at public directory... I got some idea for... #178 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features that are ready to be worked on.
Projects
None yet
Development

No branches or pull requests

2 participants