Adding dependencies #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Kelsin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help resolve issue #1
Right now dependencies aren't included in this gem. You can see on it's page over at rubygem's that no dependencies are listed: http://rubygems.org/gems/omniauth-goodreads
Right now you're using Jeweler which means you need to specify dependencies in the jeweler rake task. I added those in this commit. I also cleaned up the gemspec which listed jeweler as a dev dependency 4 times. I set this to create version 0.2.0 but if you want we can change that and you can release this as whatever you want.
IMHO: Jeweler is now overrated. Bundler has the ability to generate a gem skeleton, and editing the .gemspec file by hand is super easy. Easier than learning the jeweler abstractions. This pull request however just adds the dependencies, it doesn't do anything to remove jeweler.