Update dependencies #191
Merged
Update dependencies #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ciunkos
reviewed
Apr 12, 2021
| "prettier": "2.1.1", | ||
| "jest": "26.6.3", | ||
| "lint-staged": "10.5.4", | ||
| "postcss": "8.2.10", |
There was a problem hiding this comment.
Where did it come from? PostCSS 8 has a very high update impact and can lead to broken code if the other tools are not adjusted.
Member
Author
There was a problem hiding this comment.
It's only the result of updating the rollup-plugin-postcss. In version 3.xx, the postcss in version 7 was specified as dependency: https://github.com/egoist/rollup-plugin-postcss/blob/v3.1.8/package.json
in version 4 of the rollup-plugin-postcss, postcss is specified as peer dependency (in version 8).
There was a problem hiding this comment.
OK, if everything compiles and works, I am OK with that.
Ciunkos
approved these changes
Apr 13, 2021
| "prettier": "2.1.1", | ||
| "jest": "26.6.3", | ||
| "lint-staged": "10.5.4", | ||
| "postcss": "8.2.10", |
There was a problem hiding this comment.
OK, if everything compiles and works, I am OK with that.
przemyslawzalewski
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies