Skip to content

Conversation

@przemyslawzalewski
Copy link
Member

@przemyslawzalewski przemyslawzalewski commented Jan 23, 2020

This many Greenkeeper PRs will result in package-lock.json desync for sure so I think all the dependencies should be updated at once.
As stylelint and many others already dropped Node 8 as it reached EOL, this PR also removes Node 8 support. This is a BREAKING CHANGE. Apart from that, everything seems to work correctly (example page, build, tests, linters, etc.).

This closes #59, closes #60, closes #61, closes #62, closes #63, closes #64, closes #65, closes #66, closes #67, closes #68, closes #69, closes #70, closes #71, closes #78, closes #79 and closes #80.

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   76.54%   76.54%           
=======================================
  Files           2        2           
  Lines         162      162           
  Branches       38       38           
=======================================
  Hits          124      124           
  Misses          9        9           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e191d...3fa8c51. Read the comment docs.

@marekrozmus marekrozmus merged commit 6b9254c into master Jan 23, 2020
@marekrozmus marekrozmus deleted the update_dependencies_23_01_2020 branch January 23, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants