Skip to content

Improve date validity checks #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
przemyslawzalewski merged 4 commits into from
Feb 5, 2020
Merged

Improve date validity checks #54

przemyslawzalewski merged 4 commits into from
Feb 5, 2020

Conversation

@przemyslawzalewski
Copy link
Member

@przemyslawzalewski przemyslawzalewski commented Feb 5, 2020

date/valid now checks for Invalid Date objects that despite being instances of Date are invalid.

@przemyslawzalewski przemyslawzalewski merged commit 13fa712 into master Feb 5, 2020
@przemyslawzalewski przemyslawzalewski deleted the improve_date_validity_checks branch February 5, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marekrozmus marekrozmus marekrozmus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@przemyslawzalewski @marekrozmus