Skip to content

Update blink1.js #7

Closed
wants to merge 3 commits into from

2 participants

@skeggse
skeggse commented Mar 20, 2013

Improve existing typechecking, add additional typechecking. Still needs typechecking for the on and position parameters.

See #5.

@skeggse skeggse Update blink1.js
Improve existing typechecking, add additional typechecking
66a207a
@sandeepmistry
Owner

Thanks for the pull request, could you please update the unit tests for the error scenarios. Thanks.

@skeggse skeggse Typecheck additional parameters
Typecheck the on, play, and position parameters to serverDown, play, writePatternLine and readPatternLine.
4b0321e
@skeggse
skeggse commented Mar 28, 2013

Added further typechecking as specified in #5.

@skeggse skeggse Update unit-tests.js
Add unit testing as per @sandeepmistry's request, issue #5.
8599793
@skeggse
skeggse commented Mar 28, 2013

Added unit tests for @sandeepmistry.

@skeggse
skeggse commented Mar 28, 2013

Also, sorry for the lack of newline at the end of the file. I didn't feel like actually forking and cloning the repo so I just edited it within GitHub, which apparently disregards final newlines. Hooray ocd.

@sandeepmistry
Owner

Commit 41688a0 takes care of this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.