New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: implement `ns snapshot` #1081

Merged
merged 9 commits into from Jun 5, 2018

Conversation

Projects
None yet
2 participants
@jcrussell
Contributor

jcrussell commented Mar 13, 2018

Please wait for 2.5 to merge.

Calls migrate on all the VMs in the namespace. Writes a launch script
that can be read to relaunch the snapshot from the migrate files.

Very limited testing so far.

Updates #1079.

@glattercj

various: implement `ns snapshot`
Calls migrate on all the VMs in the namespace. Writes a launch script
that can be read to relaunch the snapshot from the migrate files.

Very limited testing so far.

Updates #1079.

@jcrussell jcrussell added this to the 2.5 milestone Mar 13, 2018

@jcrussell

This comment has been minimized.

Contributor

jcrussell commented Mar 13, 2018

Tests failed because travis doesn't have kvm for the unit tests.

jcrussell added some commits Mar 13, 2018

minimega: shift code
From misc to netconfig since it was only used in netconfig.
minimega: fix unit test for travis
Set the network drivers so that we do not have to invoke kvm.
minimega: various snapshot improvements
Check for existing snapshot of the same name before continuing. Multiply
percent complete by 100. Change `ns snapshot` to provide aggregate
counts rather than just display `vm migrate`.
@jcrussell

This comment has been minimized.

Contributor

jcrussell commented May 30, 2018

Need to fix the following minitests:

  • vlans
  • vm_config_net
  • vm_config_save

jcrussell added some commits May 30, 2018

minimega: add VM.WriteConfig
Replaces old config file with one that can be read in to configure a new
VM in the same way. Updates with `vm net` commands (still a WIP).
minimega/vlans: minor refactoring
Create a default vlans and functions to operate on it.
tests: fix for update netconfig format
NetConfig.String now omits values if they are set to the default.
@djfritz

djfritz approved these changes Jun 4, 2018

Oh boy...

LGTM

Dear programming gods, please watch over this merge...

@djfritz

This comment has been minimized.

Contributor

djfritz commented Jun 4, 2018

@jcrussell conflicts

@jcrussell jcrussell merged commit 4af408a into sandia-minimega:master Jun 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrussell jcrussell deleted the jcrussell:issue-1079 branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment