Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega/ron/miniccc: add ufs to miniccc #1108

Merged
merged 14 commits into from Jun 21, 2018

Conversation

@jcrussell
Copy link
Contributor

@jcrussell jcrussell commented Jun 4, 2018

Exposes the guest filesystem to the host over the cc connection.

jcrussell added 10 commits May 31, 2018
For `cc mount`.
Initial work to expose the guest's filesystem via the cc connection and
9p. Requires tunneling yet another thing over the cc connection.

Tested and hung on the mount command... need to investigate.
Windows support.
Seems to work, need to do some refactoring on the ninep side and then
refactor this too.
Bump the vendored ninep code to post-refactored version. Update
minimega/ron/miniccc accordingly.
Mount a guest filesystem across the network to the node that runs the
command via `cc mount <uuid> ...`. Need to fix `cc mount` listing and
probably move the ccMounts into the namespace struct so that they are
namespace-aware.
Move ccMounts into the namespace struct so that cc mount is
namespace-aware. Add `clear cc mount` to unmount things. Adding locking
to prevent potential races.
Make clear cc clean up cc mounts. Change mount to read-only. Abort if
the destination for the mount does not exist.
Not really integrated into tutorial...
@jcrussell jcrussell added this to the 2.5 milestone Jun 12, 2018
@jcrussell jcrussell self-assigned this Jun 12, 2018
jcrussell added 2 commits Jun 14, 2018
Merge in the latest ninep code, update miniccc accordingly.
Drop the read-only flag since we can now write (and it didn't seem to
work). Clean up mounts when we destroy the namespace.

Probably need to also clean up the mounts when we kill a VM...
@jcrussell
Copy link
Contributor Author

@jcrussell jcrussell commented Jun 14, 2018

TODO: unmount if the VM is killed?

jcrussell added 2 commits Jun 19, 2018
To fix Windows build.
Make it clear that mounts should be unmounted before the VM is killed.
@jcrussell jcrussell assigned djfritz and unassigned jcrussell Jun 21, 2018
Copy link
Contributor

@djfritz djfritz left a comment

LGTM - what could go wrong?

@djfritz djfritz merged commit 85cf7f7 into sandia-minimega:master Jun 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jcrussell jcrussell deleted the jcrussell:issue-1107 branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.