Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega: fix vnc with namespaces #1125

Merged
merged 2 commits into from Jun 19, 2018
Merged

Conversation

@jcrussell
Copy link
Contributor

@jcrussell jcrussell commented Jun 19, 2018

Use wrapVMTargetCLI to make vnc work better with namespaces.

jcrussell added 2 commits Jun 18, 2018
Use wrapVMTargetCLI to suppress vm not found errors from hosts not
running the desired VM.

Fixes #1122
Change vnc record to run across the namespace.
@jcrussell jcrussell added this to the 2.5 milestone Jun 19, 2018
Copy link
Contributor

@djfritz djfritz left a comment

LGTM

@djfritz djfritz merged commit 79b1ef5 into sandia-minimega:master Jun 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jcrussell jcrussell deleted the jcrussell:issue-1122 branch Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.