New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega: bug fixes to `disk` #1127

Merged
merged 3 commits into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@jcrussell
Contributor

jcrussell commented Jun 20, 2018

disk should error when there is more than one partition. Fix cleanup.

jcrussell added some commits Jun 14, 2018

minimega: change default partition to ""
Making the default partition "1" means that we don't throw an error if
there is more than one partition.
minimega: remove diskInjectCleanup
Replace with three deferred functions -- otherwise we get an error
unmounting if we haven't already mounted.

@jcrussell jcrussell added this to the 2.5 milestone Jun 20, 2018

@jcrussell

This comment has been minimized.

Contributor

jcrussell commented Jun 20, 2018

Need to fix minitest.

@jcrussell jcrussell assigned jcrussell and unassigned djfritz Jun 20, 2018

tests: fix disk
Error is now printed if there are multiple partitions.

@jcrussell jcrussell assigned djfritz and unassigned jcrussell Jun 20, 2018

@djfritz

LGTM

@djfritz djfritz merged commit dddbd06 into sandia-minimega:master Jun 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrussell jcrussell deleted the jcrussell:disk branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment