Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upigor: show - sort by owner #1160
Conversation
csymonds
assigned
jcrussell
Aug 13, 2018
csymonds
requested a review
from
jcrussell
Aug 13, 2018
src/igor/show.go
Outdated
| @@ -151,7 +174,11 @@ func runShow(_ *Command, _ []string) { | ||
| } | ||
| // nameFmt will create uniform color bars for 1st column | ||
| nameFmt := "%" + strconv.Itoa(maxResNameLength) + "v" | ||
| sort.Sort(StartSorter(resarray)) | ||
| if subO { | ||
| sort.Sort(ByOwner(resarray)) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good. Do we want to sort each owner's reservations by start time? sort.Slice(resarray, func(i, j int) bool {
if resarray[i].Owner == resarray[j].Owner {
return resarray[i].StartTime < resarray[j].StartTime
}
return resarray[i].Owner < resarray[j].Owner
}) |
csymonds
merged commit 21a7944
into
sandia-minimega:master
Aug 27, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
csymonds commentedAug 13, 2018
Adding an option to the show command to allow sorting by owner name to make it easier to find reservations by owner