New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega/ron: cc filter using vm info columns #1161

Merged
merged 5 commits into from Aug 31, 2018

Conversation

Projects
None yet
2 participants
@jcrussell
Contributor

jcrussell commented Aug 20, 2018

Make it so that you can use any "vm info" column in "cc filter".

Needs testing.

jcrussell added some commits Aug 5, 2018

minimega/ron: cc filter using vm info columns
Make it so that you can use any "vm info" column in "cc filter".
ron: tweak info overwrite tags
Only overwrite if the string is nonzero.

@jcrussell jcrussell added this to the 2.5 milestone Aug 21, 2018

ron: fix panic, again
Need to check that the filter is also not nil...
@jcrussell

This comment has been minimized.

Contributor

jcrussell commented Aug 22, 2018

Fixes #966.

@djfritz

YASSS! Finally!

LGTM

@djfritz djfritz merged commit 9bc2f7a into sandia-minimega:master Aug 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrussell jcrussell deleted the jcrussell:cc-filter branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment