Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega: fix capture #1167

Merged
merged 2 commits into from Aug 31, 2018

Conversation

Projects
None yet
2 participants
@jcrussell
Copy link
Contributor

jcrussell commented Aug 22, 2018

Fixed issue with "unreachable".

jcrussell added some commits Aug 22, 2018

minimega: report location of unreachable errors
To help diagnose unreachable errors, add unreachable helper.
minimega: fix capture netflow
Removed the <file,> and <socket,> prefixes and forgot to update the
handler.

@jcrussell jcrussell added this to the 2.5 milestone Aug 23, 2018

@@ -90,6 +90,15 @@ func (m *loggingMutex) Unlock() {
log.Info("unlocked: %v:%v", file, line)
}

// unreachable returns an error when we reach a condition that should be

This comment has been minimized.

@djfritz

djfritz Aug 31, 2018

Contributor

Holy cow

@djfritz
Copy link
Contributor

djfritz left a comment

unreachable() has crazy high order meanings... still, LGTM

@djfritz djfritz merged commit cf985bb into sandia-minimega:master Aug 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrussell jcrussell deleted the jcrussell:fix-capture branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.