Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cn instead of C2 basis that will be deprecated + cleaning #800

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

mperego
Copy link
Collaborator

@mperego mperego commented Mar 25, 2022

Quadratic FE basis (C2) will be deprecated in Intrepid2, in favor of basis or variable order (Cn).
Here we use Cn, with n=2, instead of C2.

@mperego mperego requested a review from bartgol March 25, 2022 20:44
@ikalash
Copy link
Collaborator

ikalash commented Mar 25, 2022

When is the deprecation happening, @mperego ? I'll need to make similar changes in LCM.

@mperego
Copy link
Collaborator Author

mperego commented Mar 25, 2022

When is the deprecation happening, @mperego ? I'll need to make similar changes in LCM.

Ideally soon, altough we'll wait a few months before removing them. I'm trying to check whether this could be harmful to applications. I sent you and Alejandro an email for LCM.

@mperego
Copy link
Collaborator Author

mperego commented Mar 26, 2022

Not sure any longer we are going to deprecate C2 functions as they are used for quadratic meshes (whose ordering of nodes mach that of C2 but not that of Cn). Anyway taking this opportunity for a little cleanup. Removed spectral elements and quadratic meshes, that wer not tested anyay.

Copy link
Collaborator

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious: why does Intrepid2 still keeps the specialization for first order then?

@mperego
Copy link
Collaborator Author

mperego commented Mar 28, 2022

I'm curious: why does Intrepid2 still keeps the specialization for first order then?

Backword compatibility and performance. Also Cn, with n=1 is the same as C1. That's not true for C2 (because of different ordering of DoFs), which creates troubles.

@mperego mperego merged commit 2054bb1 into master Mar 28, 2022
@mperego mperego deleted the use_Cn_basis branch March 28, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants