From a0a38f8cd2f346b7ddc487fd2fad8c0af9912d39 Mon Sep 17 00:00:00 2001 From: wcjohns Date: Fri, 7 Apr 2023 13:23:18 -0700 Subject: [PATCH 1/2] Fix some downloads not presenting Save As dialog on Windows (instead went straight to Downloads folder) --- src/EnergyCalTool.cpp | 13 +++++++------ src/RelActAutoGui.cpp | 9 +++++---- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/EnergyCalTool.cpp b/src/EnergyCalTool.cpp index 6d5c2a8c..7e65ab30 100644 --- a/src/EnergyCalTool.cpp +++ b/src/EnergyCalTool.cpp @@ -685,12 +685,11 @@ class CalDisplay : public WContainerWidget m_downloadCALp = new WAnchor( WLink(m_tool->calpResources()), btndiv ); m_downloadCALp->setTarget( AnchorTarget::TargetNewWindow ); m_downloadCALp->setStyleClass( "LinkBtn DownloadLink" ); - m_downloadCALp->setText( "CALp" ); #else - m_downloadCALp = new WPushButton( "CALp", btndiv ); + m_downloadCALp = new WPushButton( btndiv ); m_downloadCALp->setIcon( "InterSpec_resources/images/download_small.svg" ); - m_downloadCALp->setLinkTarget( Wt::TargetNewWindow ); m_downloadCALp->setLink( WLink( m_tool->calpResources() ) ); + m_downloadCALp->setLinkTarget( Wt::TargetNewWindow ); m_downloadCALp->setStyleClass( "LinkBtn DownloadBtn CALp" ); #if( ANDROID ) @@ -701,6 +700,8 @@ class CalDisplay : public WContainerWidget #endif //ANDROID #endif //#if( BUILD_AS_OSX_APP || IOS ) / #else + + m_downloadCALp->setText( "CALp" ); m_uploadCALp = new WPushButton( btndiv ); m_uploadCALp->setIcon( "InterSpec_resources/images/upload_small.svg" ); @@ -1307,13 +1308,12 @@ void EnergyCalTool::initWidgets( EnergyCalTool::LayoutType layoutType ) m_downloadCALp = new WAnchor( WLink(m_calpResource), btndiv ); m_downloadCALp->setTarget( AnchorTarget::TargetNewWindow ); m_downloadCALp->setStyleClass( "LinkBtn DownloadLink CALp" ); - m_downloadCALp->setText( "CALp" ); #else - m_downloadCALp = new WPushButton( "CALp", btndiv ); + m_downloadCALp = new WPushButton( btndiv ); m_downloadCALp->setIcon( "InterSpec_resources/images/download_small.svg" ); + m_downloadCALp->setLink( WLink( m_calpResource ) ); m_downloadCALp->setLinkTarget( Wt::TargetNewWindow ); m_downloadCALp->setStyleClass( "LinkBtn DownloadBtn CALp" ); - m_downloadCALp->setLink( WLink(m_calpResource) ); #if( ANDROID ) // Using hacked saving to temporary file in Android, instead of via network download of file. @@ -1323,6 +1323,7 @@ void EnergyCalTool::initWidgets( EnergyCalTool::LayoutType layoutType ) #endif //ANDROID #endif + m_downloadCALp->setText( "CALp" ); m_downloadCALp->clicked().connect( std::bind([this](){ m_interspec->logMessage( "You can apply this CALp file later to a different spectrum by" diff --git a/src/RelActAutoGui.cpp b/src/RelActAutoGui.cpp index 7e1b8dd7..639e20ed 100644 --- a/src/RelActAutoGui.cpp +++ b/src/RelActAutoGui.cpp @@ -3767,14 +3767,13 @@ void RelActAutoGui::addDownloadAndUploadLinks( Wt::WContainerWidget *parent ) WAnchor *btn = new WAnchor( WLink(m_html_download_rsc), parent ); btn->setTarget( AnchorTarget::TargetNewWindow ); btn->setStyleClass( "LinkBtn DownloadLink RelActDownload" ); - btn->setText( "HTML Report" ); #else - WPushButton *btn = new WPushButton( "HTML Report", parent ); + WPushButton *btn = new WPushButton( parent ); btn->setIcon( "InterSpec_resources/images/download_small.svg" ); + btn->setLink( WLink( m_html_download_rsc ) ); btn->setLinkTarget( Wt::TargetNewWindow ); btn->setStyleClass( "LinkBtn DownloadBtn RelActDownload" ); - btn->setLink( WLink(m_html_download_rsc) ); - + #if( ANDROID ) // Using hacked saving to temporary file in Android, instead of via network download of file. m_downloadHtmlReport->clicked().connect( std::bind([this](){ @@ -3783,6 +3782,8 @@ void RelActAutoGui::addDownloadAndUploadLinks( Wt::WContainerWidget *parent ) #endif //ANDROID #endif + + btn->setText( "HTML Report" ); m_calc_started.connect( btn, &WWidget::disable ); m_calc_failed.connect( btn, &WWidget::disable ); From 551d0a234992fbdf824918bebebb03b2cfcca71b Mon Sep 17 00:00:00 2001 From: wcjohns Date: Fri, 7 Apr 2023 13:31:56 -0700 Subject: [PATCH 2/2] Get rid of glitch when expanding nuclide info panel on RelActManual --- src/RelActAutoGui.cpp | 1 - src/RelActManualGui.cpp | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/RelActAutoGui.cpp b/src/RelActAutoGui.cpp index 639e20ed..22eca7cf 100644 --- a/src/RelActAutoGui.cpp +++ b/src/RelActAutoGui.cpp @@ -3780,7 +3780,6 @@ void RelActAutoGui::addDownloadAndUploadLinks( Wt::WContainerWidget *parent ) android_download_workaround( m_calpResource, "isotopics_by_nuclide.html"); }) ); #endif //ANDROID - #endif btn->setText( "HTML Report" ); diff --git a/src/RelActManualGui.cpp b/src/RelActManualGui.cpp index 8f624059..b5e69ad8 100644 --- a/src/RelActManualGui.cpp +++ b/src/RelActManualGui.cpp @@ -246,8 +246,8 @@ class ManRelEffNucDisp : public Wt::WPanel setTitle( m_nuc ? m_nuc->symbol : m_reaction->name() ); setCollapsible( true ); setCollapsed( true ); - setAnimation( { WAnimation::AnimationEffect::SlideInFromTop, - WAnimation::TimingFunction::Linear, 250 } ); + //setAnimation( { WAnimation::AnimationEffect::SlideInFromTop, + // WAnimation::TimingFunction::Linear, 250 } ); if( m_nuc ) {