-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create TriBITS Build Alongside Raw CMake Build #171
Comments
@bartlettroscoe, Compadre includes a header-only TPL that's snapshotted into its source in |
@jmgate, For now, to make your life easy, just treat as regular header files that belong to the Compadre package. NOTE: In general it is ill advised to unconditionally build an external TPL in a your package since it causes integration problems down the line. See the M12 "For external dependencies, allow installing, building, and linking against an outside copy of external software in the document: In the near future, TriBITS will support building this as an either internal package or point to an external pre-installed package (i.e. TPL). This is what the work in TriBITSPub/TriBITS#63 and TriBITSPub/TriBITS#299 will allow (which I am supposed to be working on right now instead of ATDM :-( ). That will satisfy that policy M12. |
Hey @kuberry, is your |
Hi @jmgate, it is both the executables for the tests as well as the test. The test adding could be done in a tests folder. So yes, they can be divided. |
Do the executables for the tests get run on their own as examples, or are they just there for the sake of the tests? |
Both. They both demonstrate the ability to solve many different PDEs and also they exercise portions of the code base. We don't have any 'gold-file' type tests. Most tests either get the exact solution using a polynomial manufactured solution or perform a convergence study and check the rates. |
Part of #164.
What Needs to Be Done?
We are unable to get Compadre into Trilinos without first getting it building via TriBITS. One way to do this involves inserting a TriBITS build system alongside the raw CMake build system that already exists in Compadre. This includes the following steps:
include_tribits_build
macro into the rootCMakeLists.txt
file.CMakeLists.txt
file to include the following logic:include_tribits_build()
as the first line of all otherCMakeLists.txt
files.CMakeLists.tribits.cmake
files as siblings to all otherCMakeLists.txt
files, and insert the necessary TriBITS magic to do the equivalent to what's in the sibling file.The text was updated successfully, but these errors were encountered: