Patch wildcard gauge optimization bugs #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses a bug in the 1D wildcard models that resulted from a mismatch in the gauge optimization settings used in different places in the code. We now have some basic plumbing for the GSTGaugeOptSuite that pipes the different gauge optimizations through to the badfit estimate code and makes sure that we are consistent. Also makes the wildcard models switchable on the gauge optimization in the report generation for cases where we have more than one gauge optimization used.
sserita
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses a bug in the 1D wildcard models that resulted from a mismatch in the gauge optimization settings used in different places in the code. We now have some basic plumbing for the GSTGaugeOptSuite that pipes the different gauge optimizations through to the badfit estimate code and makes sure that we are consistent. Also makes the wildcard models switchable on the gauge optimization in the report generation for cases where we have more than one gauge optimization used.
This patch follows up on the initial patch @enielse made for this issue in commit 2838034
(I actually hadn't noticed there was a recent commit targeting this until putting the PR together, funny that we both ran into this in such close succession!)