Fixes gpindices initialization issue in TPPOVM. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plumbs the 'called_from_reduce' argument of TPPOVM.__init__ into ComplementPOVMEffect and ConjugatedStatePOVMEffect so that effect gpindices aren't allocated during the intialization of a TPPOVM that originates via a __reduce__ call. Also adds logic to BasePOVM to avoid copying effect vectors, which would reset their gpindices and cause allocation down the line. This bugfix may also fix issues with copying TPPOVM objects via, e.g., deepcopy, as this uses the same control path as pickle. Lightly tested on a 1Q TP-parameterized model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumbs the 'called_from_reduce' argument of TPPOVM.init into ComplementPOVMEffect and ConjugatedStatePOVMEffect so that effect gpindices aren't allocated during the intialization of a TPPOVM that originates via a reduce call. Also adds logic to BasePOVM to avoid copying effect vectors, which would reset their gpindices and cause allocation down the line. This bugfix may also fix issues with copying TPPOVM objects via, e.g., deepcopy, as this uses the same control path as pickle. Lightly tested on a 1Q TP-parameterized model.