Merge tests which verify floating points registers save/restore during context switch #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes file changes unrelated to the two unit test. These unrelated changes should be removed. |
janciesko
requested changes
May 19, 2023
There was a problem hiding this comment.
can you point to the unrelated changes?
There was a problem hiding this comment.
I'll look at remove those changes next week.
There was a problem hiding this comment.
can you point to the unrelated changes?
|
Any updates on this? |
|
I switched laptops and needed to get my environment back up and working. Everything seems to work with |
|
@janciesko still learning github here. I look at my repo (cjhackillinois:main) and it wants me to discard 7 commits before I can sync.
I assume I would lose my 2 new unit tests, so for now I'm now doing anything. What do you recommend? |
|
Closing in favor of #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two units tests which utilize FP registers and context switch. This should allow code to use the GP registers or FP registers without an issue. Note, this code tests the use of the floating point registers (lower 64-bits) and not SIMD vector registers (upper 64-bits).