-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge tests which verify floating points registers save/restore during context switch #130
Conversation
This PR includes file changes unrelated to the two unit test. These unrelated changes should be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you point to the unrelated changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look at remove those changes next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you point to the unrelated changes?
Any updates on this? |
I switched laptops and needed to get my environment back up and working. Everything seems to work with |
@janciesko still learning github here. I look at my repo (cjhackillinois:main) and it wants me to discard 7 commits before I can sync. I assume I would lose my 2 new unit tests, so for now I'm now doing anything. What do you recommend? |
Closing in favor of #135 |
I added two units tests which utilize FP registers and context switch. This should allow code to use the GP registers or FP registers without an issue. Note, this code tests the use of the floating point registers (lower 64-bits) and not SIMD vector registers (upper 64-bits).