From dfbc2193eb75288b9ee9f3cbb92d929e63e14810 Mon Sep 17 00:00:00 2001
From: Matthew Letter <mletter@sandia.gov>
Date: Wed, 22 Jul 2020 11:18:43 -0600
Subject: [PATCH] fixing button styling for controls

---
 .../__snapshots__/LoadingPage.test.tsx.snap   |  5 +++++
 web-server/components/ControlsButton.js       |  2 +-
 .../plugin-components/LoadButton.tsx          |  2 +-
 .../plugin-components/LoadingPage.tsx         |  6 +++++
 .../plugin-components/LoadingPageButtons.tsx  | 22 +++++++------------
 .../plugin-components/types.ts                |  2 --
 6 files changed, 21 insertions(+), 18 deletions(-)

diff --git a/web-server/__tests__/plugins/slycat-timeseries-model/plugin-components/__snapshots__/LoadingPage.test.tsx.snap b/web-server/__tests__/plugins/slycat-timeseries-model/plugin-components/__snapshots__/LoadingPage.test.tsx.snap
index e1b0e7f9c..6879c48fe 100644
--- a/web-server/__tests__/plugins/slycat-timeseries-model/plugin-components/__snapshots__/LoadingPage.test.tsx.snap
+++ b/web-server/__tests__/plugins/slycat-timeseries-model/plugin-components/__snapshots__/LoadingPage.test.tsx.snap
@@ -37,6 +37,11 @@ exports[`Timeseries LoadingPage we have expected props on initial load 2`] = `
     <div
       className="row justify-content-center"
     >
+      <ConnectModal
+        callBack={[Function]}
+        hostname="hostname"
+        modalId="ConnectModal"
+      />
       <div
         className="btn-group col-8"
         role="group"
diff --git a/web-server/components/ControlsButton.js b/web-server/components/ControlsButton.js
index 7a82819a2..c0b4e3137 100644
--- a/web-server/components/ControlsButton.js
+++ b/web-server/components/ControlsButton.js
@@ -8,7 +8,7 @@ const ControlsButton = (props) => {
   })
   return props.hidden ? null : (
     <button
-      className={`${props.button_style} ${props.class}`}
+      className={`btn ${props.button_type || 'btn-sm'} ${props.button_style}`}
       id={props.id}
       type="button"
       title={props.title}
diff --git a/web-server/plugins/slycat-timeseries-model/plugin-components/LoadButton.tsx b/web-server/plugins/slycat-timeseries-model/plugin-components/LoadButton.tsx
index f3895954b..cc66804d5 100644
--- a/web-server/plugins/slycat-timeseries-model/plugin-components/LoadButton.tsx
+++ b/web-server/plugins/slycat-timeseries-model/plugin-components/LoadButton.tsx
@@ -6,7 +6,7 @@ import { LoadButtonProps } from "./types.ts";
  */
 const LoadButton: React.FC<LoadButtonProps> = (props) => (
   <button
-    className={`btn btn btn-outline-primary`}
+    className={`btn btn-outline-primary`}
     id={"pullbtn"}
     type="button"
     title={"Send a command to try manually pulling the data from the HPC and loading it the server"}
diff --git a/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPage.tsx b/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPage.tsx
index dcd9c5d3e..8bfd35285 100644
--- a/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPage.tsx
+++ b/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPage.tsx
@@ -6,6 +6,7 @@ import { JobCodes } from "./JobCodes.tsx";
 import LogList from "./LogList.tsx";
 import LoadingPageButtons from "./LoadingPageButtons.tsx";
 import InfoBar from "./InfoBar.tsx";
+import ConnectModal from "components/ConnectModal.tsx";
 /**
  * react component used to create a loading page
  *
@@ -206,6 +207,11 @@ export default class LoadingPage extends React.Component<LoadingPageProps, Loadi
             />
           </div>
           <div className="row justify-content-center">
+            <ConnectModal
+              hostname={this.props.hostname}
+              modalId={this.state.modalId}
+              callBack={this.connectModalCallBack}
+            />
             <div className="btn-group col-8" role="group">
               <LoadingPageButtons
                 hostname={this.props.hostname}
diff --git a/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPageButtons.tsx b/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPageButtons.tsx
index 0e8c10616..4f37007ab 100644
--- a/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPageButtons.tsx
+++ b/web-server/plugins/slycat-timeseries-model/plugin-components/LoadingPageButtons.tsx
@@ -1,26 +1,20 @@
 import * as React from "react";
-import ConnectModal from "components/ConnectModal.tsx";
 import ControlsButton from "components/ControlsButton.js";
 import LoadButton from "./LoadButton.tsx";
 import { LoadingPageButtonsProps } from "./types.ts";
 
 /**
  *  loads the buttons for the loading page for timeseries model
- * @param props 
+ * @param props
  */
 const LoadingPageButtons: React.FC<LoadingPageButtonsProps> = (props) => {
   // wait until all the jquery stuff is loaded
-  $( document ).ready(function( $ ) {
+  $(document).ready(function ($) {
     // enable tooltips
     $('[data-toggle="tooltip"]').tooltip();
-  })
+  });
   return (
     <React.Fragment>
-      <ConnectModal
-        hostname={props.hostname}
-        modalId={props.modalId}
-        callBack={props.connectModalCallBack}
-      />
       <button
         className="btn btn-outline-primary"
         type="button"
@@ -33,13 +27,13 @@ const LoadingPageButtons: React.FC<LoadingPageButtonsProps> = (props) => {
         Job status meanings
       </button>
       <button
-        className={`btn btn btn-outline-primary`}
+        className={`btn btn-outline-primary`}
         id={"pullbtn"}
         type="button"
-        title={"Send command to the HPC to cancel the current job if the status is pending or running"}
-        disabled={
-          !props.jobStatus.includes("PENDING") && !props.jobStatus.includes("RUNNING")
+        title={
+          "Send command to the HPC to cancel the current job if the status is pending or running"
         }
+        disabled={!props.jobStatus.includes("PENDING") && !props.jobStatus.includes("RUNNING")}
         onClick={() => props.cancelJob()}
       >
         {"Cancel job"}
@@ -54,7 +48,7 @@ const LoadingPageButtons: React.FC<LoadingPageButtonsProps> = (props) => {
           title={"Connect to HPC"}
           data_toggle="modal"
           data_target={"#" + props.modalId}
-          button_style={"btn btn-outline-primary"}
+          button_type={"btn-outline-primary"}
           id="controls-button-death"
         />
       )}
diff --git a/web-server/plugins/slycat-timeseries-model/plugin-components/types.ts b/web-server/plugins/slycat-timeseries-model/plugin-components/types.ts
index 525a6ff36..eda49e393 100644
--- a/web-server/plugins/slycat-timeseries-model/plugin-components/types.ts
+++ b/web-server/plugins/slycat-timeseries-model/plugin-components/types.ts
@@ -60,9 +60,7 @@ export interface InfoBarProps {
 }
 
 export interface LoadingPageButtonsProps {
-  hostname: string
   modalId: string
-  connectModalCallBack: (sessionExists: boolean, loadingData: boolean) => void
   jobStatus: string
   cancelJob: () => void
   pullHPCData: () => void