-
Notifications
You must be signed in to change notification settings - Fork 1
docs: Include output from first example in README #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideAdds the concrete console output of the first staged script example to the top-level README and Sphinx index to better showcase what running the example looks like. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `doc/source/index.rst:105` </location>
<code_context>
my_script.main(sys.argv[1:])
```
+Executing the script then yields
+```
+>>> my_staged_script.py --stage hello goodbye
</code_context>
<issue_to_address>
**nitpick (typo):** Consider adding a colon at the end of this sentence to clearly introduce the following output.
Since this line introduces the console output, consider phrasing it as `Executing the script then yields:` for smoother readability.
```suggestion
Executing the script then yields:
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 177 177
Branches 15 15
=========================================
Hits 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
084f0f1 to
f020dba
Compare
To better advertise what the package provides, without requiring the reader to jump to (or further into) the documentation, include the output from running the first example script with both stages defined in the `README.md` file, which will be displayed on GitHub and PyPI, and the `index.rst` file, which will be displayed on ReadTheDocs. Note that this incurs a minimal maintenance burden, in that we'll need to keep this output up-to-date with any changes to the package that affect the output.
f020dba to
fd78f50
Compare
|
@william76, is this what you had in mind? |
|
@jmgate Yup, that looks great! I think you had something like that on the RTD pages. It's nice to have that on the readme here on github too since that'll be the first place many people look and will give them an idea of what the package does. also... LGTM! 😉 |
Type: Documentation
Description
To better advertise what the package provides, without requiring the reader to jump to (or further into) the documentation, include the output from running the first example script with both stages defined in the
README.mdfile, which will be displayed on GitHub and PyPI, and theindex.rstfile, which will be displayed on ReadTheDocs.Note that this incurs a minimal maintenance burden, in that we'll need to keep this output up-to-date with any changes to the package that affect the output.
Related Issues/PRs
Closes #249.
Summary by Sourcery
Documentation: