GitHub login redirect loop if ":80" appears in BASE_URL

[paulproteus]

I'm currently experiencing a redirect loop where on http://tpcikmmyjjapslvl.sandcats-dev.sandstorm.io/ (a test Sandstorm install I created), whenever I try to log in as the first GitHub user, I get sent to /, and then immediately redirected to /setup. Additionally, login does not seem to be succeeding.

I'll attempt to diagnose but wanted to leave a note that I'm experiencing something weird.

[paulproteus]

OK, my BASE_URL and WILDCARD_HOST used to be:

BASE_URL=http://tpcikmmyjjapslvl.sandcats-dev.sandstorm.io:80
WILDCARD_HOST=*.tpcikmmyjjapslvl.sandcats-dev.sandstorm.io:80

and I was getting this "warning" (perhaps treated as an error?) in /opt/sandstorm/var/log/sandstorm.log:

{"line":"398","file":"oauth_server.js","message":"Error in OAuth Server: redirectUrl (http://tpcikmmyjjapslvl.sandcats-dev.sandstorm.io/setup/user) is not on the same host as the app (http://tpcikmmyjjapslvl.sandcats-dev.sandstorm.io:80/)","time":{"$date":1469070069967},"level":"warn"}

and when I changed my BASE_URL to not have the :80 then the problem resolved itself.

[paulproteus]

I guess tomorrow I will attempt to reproduce this, and then propose a fix. I plan to change things so that install.sh uses port 80 more often, so this is going to start affecting more users.

[paulproteus]

Re-opening because it's not really resolved, just worked-around in install.sh.

[paulproteus]

Removing milestone for this; the workaround is adequate for the needs expressed in the milestone.