New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download backup" should create data within a wrapper directory #240

Closed
paulproteus opened this Issue Feb 4, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@paulproteus
Member

paulproteus commented Feb 4, 2015

Steps to reproduce:

  • Log into a Sandstorm instance, then create an instance of an app, and use it for a little while.
  • Click the "Download backup" link at the top.
  • Find a *.zip file in your ~/Downloads directory.
  • Unzip it.
  • Discover it has created files at the top level.

Expected behavior:

  • The data should be within a directory like grain-id/var or something like that, to avoid stomping on files in the current working directory where the user unzipped it.

This issue is probably pretty bite-sized, so marking as such.

@kentonv

This comment has been minimized.

Member

kentonv commented Feb 4, 2015

Hmm, traditionally zip etiquette says not to create a wrapper directory -- this differs from tar etiquette. GUI-based unzip tools (particularly on Windows/Mac) typically create a wrapper directory automatically. Unfortunately the unix unzip tool decides to match tar here, despite annoyingly not matching tar on so many other points.

@paulproteus

This comment has been minimized.

Member

paulproteus commented Feb 4, 2015

Interesting, okay. I could live with this staying the way it is if we also document it somewhere.

@ocdtrekkie

This comment has been minimized.

Contributor

ocdtrekkie commented Feb 4, 2015

I think I'd second @kentonv on that. I actually always make sure the zip tool is creating an appropriate folder for just this reason (and it usually does), and nothing makes me sadder then lots of nested folders to get to the stuff.

@paulproteus

This comment has been minimized.

Member

paulproteus commented Feb 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment