New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload/download backups on DDP host rather than main host. #2877

Merged
merged 3 commits into from Mar 1, 2017

Conversation

Projects
None yet
2 participants
@kentonv
Member

kentonv commented Feb 28, 2017

When a separate DDP host is specified, it should be used for all "dynamic" interaction, where the main host is used only for static content (e.g. static HTML, Javascript, CSS, images).

See also: https://sandstorm.io/news/2017-02-28-cloudbleed

Upload/download backups on DDP host rather than main host.
When a separate DDP host is specified, it should be used for all "dynamic" interaction, where the main host is used only for static content (e.g. static HTML, Javascript, CSS, images).

See also: https://sandstorm.io/news/2017-02-28-cloudbleed

@kentonv kentonv requested a review from dwrensha Feb 28, 2017

@dwrensha

This comment has been minimized.

Show comment
Hide comment
@dwrensha

dwrensha Mar 1, 2017

Member

What about spk uploads? It looks like it would be easy to make this change for them as well.

I suppose nothing needs to be done about profile image uploads, because they already go through the "static" host.

Member

dwrensha commented Mar 1, 2017

What about spk uploads? It looks like it would be easy to make this change for them as well.

I suppose nothing needs to be done about profile image uploads, because they already go through the "static" host.

@kentonv

This comment has been minimized.

Show comment
Hide comment
@kentonv

kentonv Mar 1, 2017

Member

Good point, done.

(I wasn't really thinking about spk uploads since they generally do not contain secrets, but for performance reasons it's still good to upload them directly.)

Member

kentonv commented Mar 1, 2017

Good point, done.

(I wasn't really thinking about spk uploads since they generally do not contain secrets, but for performance reasons it's still good to upload them directly.)

@dwrensha

Looks good to me.

@kentonv kentonv merged commit 5051815 into master Mar 1, 2017

3 checks passed

build Integration tests passed
Details
default Build finished.
Details
js-style Checks passed.
Details

@kentonv kentonv deleted the backup-on-ddp-host branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment