New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions suport and polishing #2

Open
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@aleixq

aleixq commented Dec 15, 2014

Thank's for your work, I have done some hacking over it...:
* Some fixes and corrections.
* Initial webmention support.
* Rules integrating through actions (separated module done)
* Remove cruft coming from 1.x.
* Lookup the nid from url always, not only if drupal is in root domain directory.

aleixq added some commits Dec 11, 2014

* Some fixes and corrections.
* Initial webmention support.
* Rules polishing
* Remove cruft coming from 1.x.
* Lookup the nid from url always, not only if drupal is in root domain directory.
@sanduhrs

This comment has been minimized.

Show comment
Hide comment
@sanduhrs

sanduhrs Dec 15, 2014

Please stick to the Drupal coding standards here.
See https://www.drupal.org/coding-standards we need spaces around = and .
You can use the coder module to check your code for compliance.
See https://www.drupal.org/project/coder

Please stick to the Drupal coding standards here.
See https://www.drupal.org/coding-standards we need spaces around = and .
You can use the coder module to check your code for compliance.
See https://www.drupal.org/project/coder

@sanduhrs

This comment has been minimized.

Show comment
Hide comment
@sanduhrs

sanduhrs Dec 15, 2014

Coding standards

@sanduhrs

This comment has been minimized.

Show comment
Hide comment
@sanduhrs

sanduhrs Dec 15, 2014

Does drupal_get_normal_path resolve both, an alias and an internal path?

Does drupal_get_normal_path resolve both, an alias and an internal path?

This comment has been minimized.

Show comment
Hide comment
@aleixq

aleixq Dec 15, 2014

Owner

I think so

Owner

aleixq replied Dec 15, 2014

I think so

@sanduhrs

This comment has been minimized.

Show comment
Hide comment
@sanduhrs

sanduhrs Dec 15, 2014

If we do it like that, we need to check wether node_path[2] is empty, too.
Also: Coding standards

If we do it like that, we need to check wether node_path[2] is empty, too.
Also: Coding standards

@sanduhrs

This comment has been minimized.

Show comment
Hide comment
@sanduhrs

sanduhrs Dec 15, 2014

Coding standards

@sanduhrs

This comment has been minimized.

Show comment
Hide comment
@sanduhrs

sanduhrs Dec 15, 2014

Please leave the empty line intact.

Please leave the empty line intact.

@sanduhrs

This comment has been minimized.

Show comment
Hide comment
@sanduhrs

sanduhrs Dec 15, 2014

Thanks for your interest in the code!
You're very welcome.

Thanks for your interest in the code!
You're very welcome.

* Follow coding standards.
* lookup nid checks that node_path[2] is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment