New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'private' to type #30

Merged
merged 2 commits into from Aug 2, 2013

Conversation

Projects
None yet
3 participants
@willnet
Contributor

willnet commented Aug 2, 2013

This commit is dirty but works for me.

I have a private repo which I want to use tachikoma to. but

  • https:// requires login name and password
  • ssh:// doesn't require them (if ssh key is set) but tachikoma doesn't support

so I add 'private' to type in order to support ssh://.

If you set "ssh://github.com/user_name/private_repo.git" to url, it work.

@kyanny

This comment has been minimized.

Show comment
Hide comment
@kyanny

kyanny Aug 2, 2013

Collaborator

"#{uri.scheme}://#{github_token}@#{uri.host}#{uri.path}" may work with private repo so you can use shared strategy with valid oauth2 token.

$ git clone https://your-valid-oauth2-token@github.com/username/private-repo.git
Collaborator

kyanny commented Aug 2, 2013

"#{uri.scheme}://#{github_token}@#{uri.host}#{uri.path}" may work with private repo so you can use shared strategy with valid oauth2 token.

$ git clone https://your-valid-oauth2-token@github.com/username/private-repo.git
@kyanny

This comment has been minimized.

Show comment
Hide comment
@kyanny

kyanny Aug 2, 2013

Collaborator

I think ssh is more proper name for your new strategy.
(and shared seems unclear name, any other suggestions? Cc/ @sanemat)

Collaborator

kyanny commented Aug 2, 2013

I think ssh is more proper name for your new strategy.
(and shared seems unclear name, any other suggestions? Cc/ @sanemat)

@willnet

This comment has been minimized.

Show comment
Hide comment
@willnet

willnet Aug 2, 2013

Contributor

@kyanny You are right.

I think using ssh:// scheme at tachikoma's setting is a bad design because github provides a url whose ssh:// scheme is omitted (e.g.: git@github.com:hoge/fuga.git).

So I added a commit to use https:// at private type.

Contributor

willnet commented Aug 2, 2013

@kyanny You are right.

I think using ssh:// scheme at tachikoma's setting is a bad design because github provides a url whose ssh:// scheme is omitted (e.g.: git@github.com:hoge/fuga.git).

So I added a commit to use https:// at private type.

@kyanny

This comment has been minimized.

Show comment
Hide comment
@kyanny

kyanny Aug 2, 2013

Collaborator

👍

Collaborator

kyanny commented Aug 2, 2013

👍

kyanny added a commit that referenced this pull request Aug 2, 2013

@kyanny kyanny merged commit bd5a826 into sanemat:master Aug 2, 2013

1 check passed

default The Travis CI build passed
Details
@sanemat

This comment has been minimized.

Show comment
Hide comment
@sanemat

sanemat Aug 2, 2013

Owner

Great pull request 👍👍
Thanks @willnet, @kyanny

About fork and shared

The name of fork and shared are based on Fork & Pull Model vs Shared Repository Model, the pattern of collaboration from github article, so fork_and_pull and shared_repository are actual name of them 😵
https://help.github.com/articles/using-pull-requests#a-quick-note-on-collaborative-development-models
via: http://blog.qnyp.com/2013/05/28/pull-request-for-github-beginners/

fork, itself and private_itself,...

Owner

sanemat commented Aug 2, 2013

Great pull request 👍👍
Thanks @willnet, @kyanny

About fork and shared

The name of fork and shared are based on Fork & Pull Model vs Shared Repository Model, the pattern of collaboration from github article, so fork_and_pull and shared_repository are actual name of them 😵
https://help.github.com/articles/using-pull-requests#a-quick-note-on-collaborative-development-models
via: http://blog.qnyp.com/2013/05/28/pull-request-for-github-beginners/

fork, itself and private_itself,...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment