Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom file provider to avoid collision with other plugins #151

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
3 participants
@Sh1d0w
Copy link
Contributor

commented May 8, 2019

Original issue: Sh1d0w/multi_image_picker#141

This PR changes:
  • Adds custom file provider so it does not conflict with other plugins using the file provider
@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #151 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #151      +/-   ##
=========================================
- Coverage    0.12%   0.12%   -0.01%     
=========================================
  Files          31      32       +1     
  Lines        1625    1626       +1     
  Branches      179     179              
=========================================
  Hits            2       2              
- Misses       1623    1624       +1
Impacted Files Coverage Δ
...java/com/sangcomz/fishbun/FishBunFileProvider.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3682d07...9c09b5a. Read the comment docs.

@sangcomz

This comment has been minimized.

Copy link
Owner

commented May 8, 2019

Thank you, PR
Could you give me a PR again with the develop branch?
@Sh1d0w

@Sh1d0w Sh1d0w changed the base branch from master to develop May 8, 2019

@Sh1d0w

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@sangcomz Done.

@sangcomz sangcomz merged commit 795ada8 into sangcomz:develop May 8, 2019

1 of 3 checks passed

codecov/patch 0% of diff hit (target 0.12%)
Details
codecov/project 0.12% (-0.01%) compared to 3682d07
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Sh1d0w

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

@sangcomz Thanks, any idea when it will be released?

@sangcomz

This comment has been minimized.

Copy link
Owner

commented May 10, 2019

@Sh1d0w
I will update this weekend!

@ektelat

This comment has been minimized.

Copy link

commented May 12, 2019

is there new update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.