Fix no module named homeassistant.util.distance#32
Merged
sanghviharshit merged 1 commit intoNov 7, 2023
Merged
Conversation
Owner
|
Thanks for the PR. Do you know if this will break the installs pre 2023.11.0? |
Contributor
Author
|
I believe the old module was removed in version 2022.4, so any version between then and now should work with this update. |
kbromberger
reviewed
Nov 2, 2023
* homeassistant.util.distance was deprecated in HA 2022.10 and this no module error is preventing me from setting up mila on 2023.11.0 * Use DistanceConverter.convert from homeassistant.util.unit_conversion * Fixes sanghviharshit#18
danielnolan
force-pushed
the
dan-fix-no-homeassistant-util-distance-module
branch
from
November 2, 2023 18:50
9f3233a to
c6cd4a0
Compare
Owner
|
@kbromberger mind testing this again? |
|
@sanghviharshit I can confirm these changes do fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no module error is preventing me from setting up mila on 2023.11.0
This is what I was seeing before my change to use the new DistanceConverter
