Skip to content

Fix no module named homeassistant.util.distance#32

Merged
sanghviharshit merged 1 commit into
sanghviharshit:masterfrom
danielnolan:dan-fix-no-homeassistant-util-distance-module
Nov 7, 2023
Merged

Fix no module named homeassistant.util.distance#32
sanghviharshit merged 1 commit into
sanghviharshit:masterfrom
danielnolan:dan-fix-no-homeassistant-util-distance-module

Conversation

@danielnolan

@danielnolan danielnolan commented Nov 2, 2023

Copy link
Copy Markdown
Contributor
  • homeassistant.util.distance was deprecated in HA 2022.10 and this
    no module error is preventing me from setting up mila on 2023.11.0
  • Use DistanceConverter.convert from homeassistant.util.unit_conversion
  • Fixes distance_convert deprecated #18
2023-11-01 19:17:33.252 ERROR (MainThread) [custom_components.mila.update_coordinator] Unexpected error fetching mila data: No module named 'homeassistant.util.distance'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 290, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/mila/update_coordinator.py", line 105, in _async_update_data
    await self._build_devices(data)
  File "/config/custom_components/mila/update_coordinator.py", line 119, in _build_devices
    self.devices[id] = MilaAppliance(self, self._api, id)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/mila/devices/appliance.py", line 33, in __init__
    super().__init__(coordinator, api, device_id)
  File "/config/custom_components/mila/devices/device.py", line 24, in __init__
    self._build_entities_list()
  File "/config/custom_components/mila/devices/device.py", line 92, in _build_entities_list
    from ..entities import MilaEntity
  File "/config/custom_components/mila/entities/__init__.py", line 3, in <module>
    from .location import *
  File "/config/custom_components/mila/entities/location/__init__.py", line 3, in <module>
    from .distance_sensor import MilaLocationDistanceSensor
  File "/config/custom_components/mila/entities/location/distance_sensor.py", line 9, in <module>
    from homeassistant.util.distance import convert as distance_convert
ModuleNotFoundError: No module named 'homeassistant.util.distance'

This is what I was seeing before my change to use the new DistanceConverter
Screenshot 2023-11-01 at 8 23 00 PM

@sanghviharshit

Copy link
Copy Markdown
Owner

Thanks for the PR. Do you know if this will break the installs pre 2023.11.0?

@danielnolan

Copy link
Copy Markdown
Contributor Author

I believe the old module was removed in version 2022.4, so any version between then and now should work with this update.

Comment thread custom_components/mila/entities/location/distance_sensor.py Outdated
* homeassistant.util.distance was deprecated in HA 2022.10 and this
  no module error is preventing me from setting up mila on 2023.11.0
* Use DistanceConverter.convert from homeassistant.util.unit_conversion
* Fixes sanghviharshit#18
@danielnolan
danielnolan force-pushed the dan-fix-no-homeassistant-util-distance-module branch from 9f3233a to c6cd4a0 Compare November 2, 2023 18:50
@sanghviharshit

Copy link
Copy Markdown
Owner

@kbromberger mind testing this again?

@kbromberger

Copy link
Copy Markdown

@sanghviharshit I can confirm these changes do fix the issue.

@sanghviharshit
sanghviharshit merged commit 024dce0 into sanghviharshit:master Nov 7, 2023
@danielnolan
danielnolan deleted the dan-fix-no-homeassistant-util-distance-module branch November 8, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distance_convert deprecated

3 participants