Join GitHub today
Initialize symbols before checking their annotations. #317
The Scala compiler uses laziness extensively to deal with recursive types. Annotations are one instance where an uninitialized type will be incorrect, so we call
Dec 29, 2017
1 check passed
referenced this pull request
Dec 29, 2017
I was thinking something like mid/end Jan, or beginning of Feb. There were quite a few changes to reference implementation, so I wanted to incorporate them into the next release after the rate of change stabilizes a bit (so I wanted to wait a bit). Some of these changes (I would say most important one) are already present in the recent v1.3.3.
Meanwhile, I can publish a snapshot version, if it would help. I also think that it should not be a big deal to publish a minor stable version with just this fix if you would consider this fix to be critical, though I normally trying to space out the releases so that they don't come too often. WDYT?
Mid-January would be fine as a date, what I'm more concerned about is how easy it will be to upgrade given the other changes to go into 1.3.4. Are there any breaking changes?
In the meantime, maybe instead of a snapshot you could publish a milestone (a stable version number). If a bugfix release is easy to cut I'm happy to port my changes to the 1.3.4 tag (though I tend to agree that this is not a critical fix).
Thanks for the info! v1.3.4 would be primarily focused on:
v1.3.3 already introduced some backward incompatible changes in SDL syntax. They are documented in #308. Since then we discussed it and addressed these concerns on a spec and reference implementation level. So one of the goals of v1.3.4 is to provide more backward compatibility in terms of SDL syntax with pre v1.3.3, I don't expect any major breaking changes.
Since it is not critical at the moment, I would suggest not to rush it for now (during holidays period) and proceed with original release plan.