Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(20.12 LTS backport) fix request.args.pop removing parameters inconsistently #2112

merged 2 commits into from Apr 22, 2021


Copy link

@artcg artcg commented Apr 12, 2021

No description provided.

Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #2112 (a4d1448) into 20.12LTS (35c7625) will not change coverage.
The diff coverage is 100.000%.

Impacted file tree graph

@@            Coverage Diff             @@
##           20.12LTS     #2112   +/-   ##
  Coverage    92.778%   92.778%           
  Files            29        29           
  Lines          3268      3268           
  Branches        573       573           
  Hits           3032      3032           
  Misses          159       159           
  Partials         77        77           
Impacted Files Coverage Δ
sanic/ 99.237% <100.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c7625...a4d1448. Read the comment docs.

Copy link

See #2106 and #2110

Copy link

ashleysommer commented Apr 12, 2021

Looks good.
Are there any other recent fixes from 21.3 or master that we should push back into 20.12 to make a new LTS release?

Copy link

None. Since this has been out there for at least 2 years, my thought was to roll LTS updates with the next release.

Copy link

Submitter confirmed that #2113 affects 20.12 too, so when a fix for that comes we should roll that into LTS too.

@ahopkins ahopkins self-requested a review April 22, 2021 09:44
@ahopkins ahopkins merged commit cbb77b5 into sanic-org:20.12LTS Apr 22, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants