Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin uvloop #2129

merged 3 commits into from Oct 2, 2021

unpin uvloop #2129

merged 3 commits into from Oct 2, 2021


Copy link

@graingert graingert commented May 4, 2021

MagicStack/uvloop#401 now sets python_requires and so as long as you ignore the broken versions of uvloop==0.15.0 and 0.15.1 so you can still support py3.6 here

0.15.0 and 0.15.1 have been yanked so this pinning can go away completely!

Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2129 (4f5faa4) into 20.12LTS (cbb77b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           20.12LTS     #2129   +/-   ##
  Coverage    92.778%   92.778%           
  Files            29        29           
  Lines          3268      3268           
  Branches        573       573           
  Hits           3032      3032           
  Misses          159       159           
  Partials         77        77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb77b5...4f5faa4. Read the comment docs.

ahopkins previously approved these changes May 31, 2021
Copy link

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, but for several reasons we are not going to go back to supporting Python 3.6 for v21. But, this is good for v20.12

@ahopkins ahopkins added the LTS label May 31, 2021 Outdated Show resolved Hide resolved
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@stale stale bot added the stale label Oct 2, 2021
Copy link
Contributor Author

This isn't stale

@stale stale bot removed the stale label Oct 2, 2021
@ahopkins ahopkins merged commit 89d9424 into sanic-org:20.12LTS Oct 2, 2021
@graingert graingert deleted the patch-1 branch October 2, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants