Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: websocket dependency for websockets 9.1 security fix #2366

merged 7 commits into from Jan 16, 2022


Copy link

Security fix in websockets dependency

@sjsadowski sjsadowski marked this pull request as ready for review January 11, 2022 15:07
Copy link

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested locally? Does it also work with 10? Maybe that should be the upper limit?

Copy link
Contributor Author

@ahopkins I wanted to minimize the change for the LTS, it probably could be 10 but I think the minimal change makes more sense in this particular scope. We do have it as 10 in the current LTS.

Copy link

ahopkins commented Jan 11, 2022

Will get this released as soon as I can. This was last released when we had Travis, so we also need to configure the branch to run CI with GH.

ahopkins previously approved these changes Jan 11, 2022
@ahopkins ahopkins merged commit 6e55e73 into 20.12LTS Jan 16, 2022
19 of 21 checks passed
@ahopkins ahopkins deleted the 20.12LTS-wsfix2201 branch January 16, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Update websockets dependency for security remediation
2 participants