Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consistent exception naming #2420

Merged
merged 6 commits into from May 12, 2022
Merged

refactor: consistent exception naming #2420

merged 6 commits into from May 12, 2022

Conversation

prryplatypus
Copy link
Member

@prryplatypus prryplatypus commented Apr 1, 2022

Names exceptions consistently, so they match the corresponding HTTP code message.

  • Modify exceptions
  • Modify uses in code
  • Modify tests
  • Add tests

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #2420 (ac9345d) into main (2bfa65e) will decrease coverage by 0.049%.
The diff coverage is 92.857%.

@@              Coverage Diff              @@
##              main     #2420       +/-   ##
=============================================
- Coverage   87.225%   87.176%   -0.050%     
=============================================
  Files           60        60               
  Lines         5057      5061        +4     
  Branches       909       909               
=============================================
+ Hits          4411      4412        +1     
- Misses         475       477        +2     
- Partials       171       172        +1     
Impacted Files Coverage Δ
sanic/app.py 88.571% <0.000%> (ø)
sanic/http.py 87.162% <ø> (ø)
sanic/mixins/routes.py 92.800% <50.000%> (ø)
sanic/errorpages.py 97.938% <100.000%> (ø)
sanic/exceptions.py 98.888% <100.000%> (+0.051%) ⬆️
sanic/handlers.py 95.384% <100.000%> (ø)
sanic/mixins/listeners.py 96.428% <100.000%> (ø)
sanic/models/asgi.py 100.000% <100.000%> (ø)
sanic/request.py 96.327% <100.000%> (ø)
sanic/router.py 95.789% <100.000%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bfa65e...ac9345d. Read the comment docs.

@prryplatypus prryplatypus marked this pull request as ready for review April 1, 2022 17:25
@prryplatypus prryplatypus requested a review from a team as a code owner April 1, 2022 17:25
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those small touches that screams of polish. Nicely done, and thanks for adding this.

@ahopkins ahopkins merged commit 86ae5f9 into sanic-org:main May 12, 2022
27 checks passed
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants