Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: easier websocket interface annotation #2438

Merged
merged 2 commits into from Apr 24, 2022
Merged

feat: easier websocket interface annotation #2438

merged 2 commits into from Apr 24, 2022

Conversation

SaidBySolo
Copy link
Member

close #2437

@SaidBySolo SaidBySolo requested a review from a team as a code owner April 24, 2022 08:58
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2438 (0125c79) into main (cc97287) will increase coverage by 0.002%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2438       +/-   ##
=============================================
+ Coverage   87.135%   87.138%   +0.002%     
=============================================
  Files           60        60               
  Lines         5045      5046        +1     
  Branches       908       908               
=============================================
+ Hits          4396      4397        +1     
  Misses         477       477               
  Partials       172       172               
Impacted Files Coverage Δ
sanic/__init__.py 100.000% <100.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc97287...0125c79. Read the comment docs.

@ahopkins
Copy link
Member

Thanks @SaidBySolo

@ahopkins ahopkins merged commit 3a6cc73 into sanic-org:main Apr 24, 2022
27 checks passed
@thibautd
Copy link

Thanks @SaidBySolo !

ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier websocket interface annotation
3 participants