Resolve typing of stacked route definitions #2455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Because of the weird necessity to return a route object for a static route, there is a
RouteWrapper
type that is meant to handle this use case. However, none of the convenience decorators (app.get
,app.post
, etc) will ever hit this use case. Therefore they can returnRouteHandler
.This overly general typing was causing type annotation failures for this pattern, even though it is intentionally supported:
This PR resolves the issue (even if not for
app.route
).