Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing spaces in CLI error message #2485

Merged
merged 1 commit into from Jun 26, 2022
Merged

Conversation

prryplatypus
Copy link
Member

No description provided.

@prryplatypus prryplatypus requested a review from a team as a code owner June 24, 2022 17:24
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #2485 (6c063d0) into main (6c48c8b) will increase coverage by 0.058%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              main     #2485       +/-   ##
=============================================
+ Coverage   87.269%   87.328%   +0.058%     
=============================================
  Files           60        60               
  Lines         5098      5098               
  Branches       913       913               
=============================================
+ Hits          4449      4452        +3     
+ Misses         476       474        -2     
+ Partials       173       172        -1     
Impacted Files Coverage Δ
sanic/server/protocols/http_protocol.py 87.500% <0.000%> (+3.409%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c48c8b...6c063d0. Read the comment docs.

@ahopkins ahopkins merged commit 0e1bf89 into main Jun 26, 2022
27 checks passed
@ahopkins ahopkins deleted the fix/factory-error-message branch June 26, 2022 07:38
"Module is not a Sanic app, it is a"
"Module is not a Sanic app, it is a "
f"{app_type_name}\n"
" If this callable returns a"
" If this callable returns a "
f"Sanic instance try: \n{solution}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ought to be using a single f string literal specifically to avoid this type of problem. And the line length limitation should be long enough to fit that on a single line (or allow breaking the rule for a literal).

These are just my notes for improving code quality in general (and for reconsideration of black settings), not asking for any immediate changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants