Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve file cache control header calculation #2486

Merged
merged 5 commits into from Jun 26, 2022

Conversation

ChihweiLHBird
Copy link
Member

  1. Microseconds in datetime should be removed for HTTP protocol.
  2. Get last_modified from async file operation instead of the non-async pathlib function.

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #2486 (de9fb31) into main (0e1bf89) will increase coverage by 0.002%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2486       +/-   ##
=============================================
+ Coverage   87.269%   87.272%   +0.002%     
=============================================
  Files           60        60               
  Lines         5098      5099        +1     
  Branches       913       913               
=============================================
+ Hits          4449      4450        +1     
  Misses         476       476               
  Partials       173       173               
Impacted Files Coverage Δ
sanic/response.py 89.285% <100.000%> (+0.054%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1bf89...de9fb31. Read the comment docs.

@ChihweiLHBird ChihweiLHBird marked this pull request as draft Jun 25, 2022
@ChihweiLHBird ChihweiLHBird marked this pull request as ready for review Jun 26, 2022
@ahopkins ahopkins merged commit 70382f2 into main Jun 26, 2022
27 checks passed
@ahopkins ahopkins deleted the zhiwei/cache-control-fix branch Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants