Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 22.6 #2487

Merged
merged 80 commits into from Jun 28, 2022
Merged

Release 22.6 #2487

merged 80 commits into from Jun 28, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jun 26, 2022

Removal of deprecated items:

  • Optional application registry
  • Execution of custom handlers after some part of response was sent
  • Configuring fallback handlers on the ErrorHandler
  • Custom LOGO setting
  • sanic.response.stream
  • AsyncioServer.init

Deprecations:

  • ErrorHandler.finalize (it no longer serves any purpose, but will not break if called)

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #2487 (0e5df3e) into main (aba333b) will decrease coverage by 0.103%.
The diff coverage is 90.625%.

@@              Coverage Diff              @@
##              main     #2487       +/-   ##
=============================================
- Coverage   87.506%   87.403%   -0.104%     
=============================================
  Files           69        69               
  Lines         5587      5549       -38     
  Branches       974       964       -10     
=============================================
- Hits          4889      4850       -39     
- Misses         506       508        +2     
+ Partials       192       191        -1     
Impacted Files Coverage Δ
sanic/response.py 89.119% <ø> (-1.651%) ⬇️
sanic/server/async_server.py 85.964% <ø> (-1.132%) ⬇️
sanic/server/runners.py 91.071% <66.666%> (-0.954%) ⬇️
sanic/http/http3.py 81.666% <88.888%> (-0.356%) ⬇️
sanic/__version__.py 100.000% <100.000%> (ø)
sanic/app.py 88.675% <100.000%> (-0.108%) ⬇️
sanic/config.py 98.591% <100.000%> (-0.742%) ⬇️
sanic/handlers.py 98.076% <100.000%> (+2.692%) ⬆️
sanic/mixins/routes.py 92.741% <100.000%> (-0.059%) ⬇️
sanic/mixins/runner.py 94.274% <100.000%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba333b...0e5df3e. Read the comment docs.

@ahopkins ahopkins marked this pull request as ready for review Jun 28, 2022
@ahopkins ahopkins requested review from a team as code owners Jun 28, 2022
@ahopkins ahopkins merged commit 13d5a44 into main Jun 28, 2022
27 checks passed
@ahopkins ahopkins deleted the release-22.6 branch Jun 28, 2022
Kyle-Verhoog added a commit to Kyle-Verhoog/dd-trace-py that referenced this pull request Jun 30, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.
Kyle-Verhoog added a commit to Kyle-Verhoog/dd-trace-py that referenced this pull request Jun 30, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.
Kyle-Verhoog added a commit to Kyle-Verhoog/dd-trace-py that referenced this pull request Jun 30, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.
Kyle-Verhoog added a commit to Kyle-Verhoog/dd-trace-py that referenced this pull request Jun 30, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.
Kyle-Verhoog added a commit to DataDog/dd-trace-py that referenced this pull request Jun 30, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.
mergify bot pushed a commit to DataDog/dd-trace-py that referenced this pull request Jul 1, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
mergify bot pushed a commit to DataDog/dd-trace-py that referenced this pull request Jul 1, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
mergify bot pushed a commit to DataDog/dd-trace-py that referenced this pull request Jul 1, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
mergify bot pushed a commit to DataDog/dd-trace-py that referenced this pull request Jul 1, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
Kyle-Verhoog added a commit to DataDog/dd-trace-py that referenced this pull request Jul 1, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Kyle-Verhoog added a commit to DataDog/dd-trace-py that referenced this pull request Jul 1, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Kyle-Verhoog added a commit to DataDog/dd-trace-py that referenced this pull request Jul 1, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Kyle-Verhoog added a commit to DataDog/dd-trace-py that referenced this pull request Jul 5, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
mergify bot pushed a commit to DataDog/dd-trace-py that referenced this pull request Aug 16, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
brettlangdon pushed a commit to DataDog/dd-trace-py that referenced this pull request Aug 17, 2022
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant