Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path.parts instead of match #2508

Merged
merged 1 commit into from Jul 31, 2022
Merged

Use path.parts instead of match #2508

merged 1 commit into from Jul 31, 2022

Conversation

ahopkins
Copy link
Member

Small change to improve this logic.

@ahopkins ahopkins requested a review from a team as a code owner Jul 31, 2022
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #2508 (a123331) into main (e100a14) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #2508   +/-   ##
=========================================
  Coverage   87.392%   87.392%           
=========================================
  Files           69        69           
  Lines         5560      5560           
  Branches       966       966           
=========================================
  Hits          4859      4859           
  Misses         509       509           
  Partials       192       192           
Impacted Files Coverage Δ
sanic/mixins/routes.py 93.700% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e100a14...a123331. Read the comment docs.

@ChihweiLHBird
Copy link
Member

Is it faster than match?

@ahopkins ahopkins merged commit 3def3d3 into main Jul 31, 2022
27 checks passed
@ahopkins ahopkins deleted the pr2495-fix branch Jul 31, 2022
@ahopkins
Copy link
Member Author

Yes

ahopkins added a commit that referenced this pull request Jul 31, 2022
ahopkins added a commit that referenced this pull request Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants