-
Notifications
You must be signed in to change notification settings - Fork 0
Replace react-color with @uiw/react-color #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4ca159b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
stipsan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot It doesn't look quite right, maybe you need to use some internals from @uiw/react-color-sketch?
Btw this repo uses React Compiler so you can remove the usage of useMemo and useCallback
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
Fixed in fc6e420:
|
stipsan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the ColorPickerInner doesn't fill the width like ColorPicker used to. It's now a square ratio no matter what.
On the alpha and hue sliders the thumb style is a circle, not the rounded vertical rectangle like previously (which looks like style-wise, we want to preserve the style feel)
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
Fixed in 60c9151:
|
stipsan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot almost there, the saturation input is now perfect. The checkboard pattern is a bit too tall, it shows 1 and a half checker rows, it should show two rows on the alpha and hue sliders.
The slider thumb itself is the right design now, but is a bit too tall so it clips off the bottom end.
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
Fixed in 0ac4bfd:
|
stipsan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot checkerboard is slightly worse now. On the two sliders I mentioned it now shows almost only 1 row.
And on the color preview the checkerboard shows 2 rows, but the checker pattern are way too large blocks now.
The slider thumbs are still getting clipped at the bottom, I'm not sure if their height changed at all
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
Fixed in 0da1239:
|
stipsan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot checkerboard is completely whacked out now. I think you're falsely assuming that setting backgound-size is enough, it seems like the Checkboard element itself is getting stretched and what not now. The thumb track element is still getting clipped btw just like before.
Co-authored-by: stipsan <81981+stipsan@users.noreply.github.com>
Fixed in 4ca159b:
|
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.