Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Rewrite gulpfile #1781

Merged
merged 4 commits into from
Mar 17, 2020
Merged

[chore] Rewrite gulpfile #1781

merged 4 commits into from
Mar 17, 2020

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Mar 13, 2020

This is a ground-up rewrite of our gulpfile which had gotten a bit out of hand complexity-wise and was riddled with unpredictable behavior and errors.

This new version takes a simpler (and more robust) approach of defining separate tasks for every package (running with the package folder as cwd). Each individual package's build tasks are run in parallell. As an added bonus this will also validate the project setup of each package.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

@bjoerge bjoerge requested a review from rexxars March 13, 2020 14:37
@vercel
Copy link

vercel bot commented Mar 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/sanity-io/test-studio/pu9be1vjv
✅ Preview: https://test-studio-git-rewrite-gulpfile.sanity-io.now.sh

@rexxars
Copy link
Member

rexxars commented Mar 13, 2020

Very excited about this! Could you rebase from next?

@bjoerge
Copy link
Member Author

bjoerge commented Mar 16, 2020

Rebased ✅

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@bjoerge bjoerge merged commit 7e0893b into next Mar 17, 2020
@bjoerge bjoerge deleted the rewrite-gulpfile branch March 17, 2020 08:34
skogsmaskin pushed a commit that referenced this pull request Mar 19, 2020
* Rewrite gulpfile

* Expose build task

* Add studio tasks, improve output and misc. cleanup

* [chore] Exclude packages that doesn't follow the src/lib convention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants