Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Template::Liquid->render() respect a preexisting context #4

Merged
merged 2 commits into from Feb 13, 2020

Conversation

@Corion
Copy link

Corion commented May 25, 2018

This is mostly to make Template::LiquidX::Tag::Include actually work. This should close sanko/Template-LiquidX-Tag-Include#1 , as rendering variables then magically works.

I've also added a test that documents how I think things should behave...

This is mostly to make Template::LiquidX::Tag::Include actually work
@sanko sanko force-pushed the sanko:master branch from 8a0c3e4 to 03fa103 Jan 24, 2020
@sanko sanko force-pushed the sanko:master branch from 64ed31a to 42cebef Feb 6, 2020
@sanko

This comment has been minimized.

Copy link
Owner

sanko commented Feb 13, 2020

IIRC, Template::LiquidX::Tag::Include was based on (an old version of) Jekyll's include tag which worked around this issue with explicit parameter passing. It's been a long time since I used github Pages, the include tag, and Liquid itself actively... I'm good with this PR.

Apologies for taking so long.

@sanko sanko merged commit 1c8ef23 into sanko:master Feb 13, 2020
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
sanko added a commit that referenced this pull request Feb 13, 2020
Changelog diff is:

diff --git a/Changes b/Changes
index 1563588..30361a0 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,8 @@

 {{$NEXT}}

+1.0.16 2020-02-13T20:39:23Z
+
   - Make Template::Liquid->render() respect a preexisting context (PR #4, Corion)
   - For limit modified (PR #5, Corion)
   - Platform related test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.