Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For limit modified #5

Merged
merged 2 commits into from Feb 13, 2020
Merged

For limit modified #5

merged 2 commits into from Feb 13, 2020

Conversation

Corion
Copy link

@Corion Corion commented Jul 27, 2018

This fixes a bug where using a :limit attribute would truncate a list:

First: {% for post in posts limit:1 %}{{ post }}{% endfor %}
---
{% for post in posts limit:10 %}{{post}},{% endfor %}

The above will only render the first element of the list in both loops, instead of rendering the single element as the first loop, and elements 1 to 10 in the second loop.

Max Maischein added 2 commits May 25, 2018 17:31
This is mostly to make Template::LiquidX::Tag::Include actually work
The test is a half-truth, but close enough
@Corion
Copy link
Author

Corion commented Jul 27, 2018

I just noticed - I built this pull request on the previous, but the files involved etc. are separate, so you can treat them as separate.

@sanko sanko merged commit 8458acd into sanko:master Feb 13, 2020
sanko added a commit that referenced this pull request Feb 13, 2020
Changelog diff is:

diff --git a/Changes b/Changes
index 1563588..30361a0 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,8 @@

 {{$NEXT}}

+1.0.16 2020-02-13T20:39:23Z
+
   - Make Template::Liquid->render() respect a preexisting context (PR #4, Corion)
   - For limit modified (PR #5, Corion)
   - Platform related test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants