Skip to content

GTA III: Bring back PLAYER_ACTOR and ONMISSION variables #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
x87 opened this issue Jul 18, 2020 · 0 comments · Fixed by #4
Closed

GTA III: Bring back PLAYER_ACTOR and ONMISSION variables #3

x87 opened this issue Jul 18, 2020 · 0 comments · Fixed by #4
Labels
bug Something isn't working

Comments

@x87
Copy link
Collaborator

x87 commented Jul 18, 2020

11=script_controlled_player
207=flag_player_on_mission

conventionally these variables were named PLAYER_ACTOR and ONMISSION respectively. Changing them may break CLEO scripts assuming they are safe to use as they get compiled using randomly available IDs and thus wouldn't match the code in the main.scm. While this is not recommended to use global variables in CLEO script, these two are well-known exceptions
@x87 x87 changed the title Bring back PLAYER_ACTOR and ONMISSION variables GTA III: Bring back PLAYER_ACTOR and ONMISSION variables Jul 18, 2020
@x87 x87 added the bug Something isn't working label Jul 18, 2020
@x87 x87 mentioned this issue Aug 2, 2020
Merged
@x87 x87 closed this as completed in #4 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

version 3.4.0 sannybuilder/data
1 participant
@x87