Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Id corrupted when duplicated in 2dfx section of IDE file #120

Closed
x87 opened this issue Dec 27, 2020 · 1 comment
Closed

Model Id corrupted when duplicated in 2dfx section of IDE file #120

x87 opened this issue Dec 27, 2020 · 1 comment
Labels
priority:p2 Medium priority scope:disassembler type:bug Something isn't working
Milestone

Comments

@x87
Copy link
Collaborator

x87 commented Dec 27, 2020

@XMDS I see the issue now. Actually disassembler does not use GetObjectID that had a bug which I fixed. Instead it reads IDE configuration and makes its own map of model names and ids that suffers from the same problem when the id is duplicated in a 2dfx section. I need to investigate what's needed to fix it.

Originally posted by @x87 in #6 (comment)

@x87 x87 added priority:p2 Medium priority scope:disassembler type:bug Something isn't working labels Dec 27, 2020
@x87
Copy link
Collaborator Author

x87 commented Dec 27, 2020

Related but not the same issue
sannybuilder/GetObjectID#1

@x87 x87 added this to the v3.7.0 milestone Jan 6, 2021
@x87 x87 mentioned this issue Jan 6, 2021
32 tasks
@x87 x87 closed this as completed Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Medium priority scope:disassembler type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant