Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add precommit hook for black, flake8 and isort #194

Closed
sansyrox opened this issue May 8, 2022 · 1 comment · Fixed by #198
Closed

[Feature Request] Add precommit hook for black, flake8 and isort #194

sansyrox opened this issue May 8, 2022 · 1 comment · Fixed by #198

Comments

@sansyrox
Copy link
Member

sansyrox commented May 8, 2022

Current Behavior

No Precommit hook

Desired Behavior

Add a precommit hook

Screenshots / Mockups

Alternatives
@chrismoradi
Copy link
Contributor

Can I work on this issue?

chrismoradi added a commit to chrismoradi/robyn that referenced this issue May 21, 2022
@chrismoradi
Adds pre-commit hooks for black, flake8, isort
e5b89ca 
Closes: sparckles#194
@chrismoradi chrismoradi mentioned this issue May 21, 2022
Merged
sansyrox pushed a commit that referenced this issue May 21, 2022
@chrismoradi
Adds pre-commit hooks for black, flake8, isort (#198)
c880c34 
* Adds pre-commit hooks for black, flake8, isort

Closes: #194

* Address PR feedback

* Config black to support 160 max line length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds pre-commit hooks for black, flake8, isort chrismoradi/robyn
2 participants
@sansyrox @chrismoradi