Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Return 500 status code when route is raising #381

Closed
AntoineRR opened this issue Jan 29, 2023 · 0 comments · Fixed by #382
Closed

[BUG] Return 500 status code when route is raising #381

AntoineRR opened this issue Jan 29, 2023 · 0 comments · Fixed by #382

Comments

@AntoineRR
Copy link
Collaborator

Description

Currently, accessing a route that raise an exception is making Robyn itself panic because we call unwrap on a PyErr.

Expected Behavior

The server shouldn't crash but return a 500 status code. Add a test for this too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: return 500 status code when route raise AntoineRR/robyn
1 participant
@AntoineRR