Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the router #52

Closed
sansyrox opened this issue Jul 15, 2021 · 5 comments
Closed

Improve the router #52

sansyrox opened this issue Jul 15, 2021 · 5 comments

Comments

@sansyrox
Copy link
Member

Improve the router. Add the ability to have variable parameters in the routes.

  • Consider if we need to use a regex based router | as ripgrep is very fast
  • Or we need to use a vanilla stack based router
  • Or we need to go all fancy and implement a radix tree (or something similar) ourselves!
@JackThomson2
Copy link
Contributor

I think using the actix router library may be a good option

@sansyrox
Copy link
Member Author

@JackThomson2 , are you talking about this: https://crates.io/crates/actix-router ?

I am unable to find any documentation for the same.

@JackThomson2
Copy link
Contributor

@sansyrox
Copy link
Member Author

sansyrox commented Jul 24, 2021

@JackThomson2 , I did read the example, but I am unable to understand what is being done here(https://github.com/actix/actix-net/blob/master/actix-router/examples/flamegraph.rs#L3) . Do you know what is happening in this line?

I am not very familiar with DSL and rust macros. Looks like I will have to go through them thoroughly.

@sansyrox
Copy link
Member Author

The latest router has been implemented: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants