Don't run sync functions in pool #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
1 similar comment
✅ Deploy Preview for robyn canceled.
|
|
@JackThomson2 , I just had a look at the PR. It looks good. But I have one question. Does it have any effect on the performance? |
|
Yeah it is much faster than previously, I'll make another PR to remove async from the function in techempowered as well should help scores go up massively |
|
@JackThomson2 , that sounds great. Thank you! :D I am not sure how Techempowered benchmarks are scored. But if it is not a dynamic request, do you think const requests would help: https://sansyrox.github.io/robyn/#/features?id=const-requests ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run synchronous functions in the tokio threadpool, this is just adding overhead. We need to acquire the GIL anyway so it won't be run async anyway. Server will still accept connections as this is done in a worker thanks to Actix design
This PR fixes #